-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
bpo-40471: Fix grammar typo in 'issubclass' docstring #19847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change @alexpovel !
While we are fixing this docstring, maybe we should change
This is equivalent to
issubclass(x, A) or issubclass(x, B) or ...
etc.
to
This is equivalent to
issubclass(x, A) or issubclass(x, B) or ...
.
as it looks to me like ...
and etc
are redundant.
@remilapeyre , what do you think about
This seems to read fluently and be in line with the preceding sentence. Otherwise, I agree with you and will update the PR with your suggestion. |
Not sure about the wording with |
Okay! The PR is updated according to your original suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexpovel, looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delayed.
Please rebase your PR to solve the conflict :)
@corona10 Done! |
Sorry, I can't merge this PR. Reason: |
1 similar comment
Sorry, I can't merge this PR. Reason: |
Sorry, I can't merge this PR. Reason: |
Thanks @alexpovel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9. |
Sorry, @alexpovel, I could not cleanly backport this to |
Sorry @alexpovel, I had trouble checking out the |
Sorry, @alexpovel, I could not cleanly backport this to |
The fix can be ported to other maintained versions of python (3.9, 3.8, 3.7). It looks like automated backport failed. @alexpovel , would you like to create backport PRs as suggested by the bot? |
Just a brief grammar fix.
See also https://bugs.python.org/issue40471.
https://bugs.python.org/issue40471
Automerge-Triggered-By: @orsenthil