Skip to content

bpo-40471: Fix grammar typo in 'issubclass' docstring #19847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020
Merged

bpo-40471: Fix grammar typo in 'issubclass' docstring #19847

merged 1 commit into from
Jun 3, 2020

Conversation

alexpovel
Copy link
Contributor

@alexpovel alexpovel commented May 1, 2020

Just a brief grammar fix.

See also https://bugs.python.org/issue40471.

https://bugs.python.org/issue40471

Automerge-Triggered-By: @orsenthil

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change @alexpovel !

While we are fixing this docstring, maybe we should change

This is equivalent to issubclass(x, A) or issubclass(x, B) or ... etc.

to

This is equivalent to issubclass(x, A) or issubclass(x, B) or ....

as it looks to me like ... and etc are redundant.

@alexpovel
Copy link
Contributor Author

alexpovel commented May 2, 2020

@remilapeyre , what do you think about

A tuple, as in issubclass(x, (A, B, ...)), may be given as the target to
check against. This is equivalent to issubclass(x, A) or issubclass(x, B) or issubclass(x, ...) etc.

This seems to read fluently and be in line with the preceding sentence.

Otherwise, I agree with you and will update the PR with your suggestion.

@remilapeyre
Copy link
Contributor

Not sure about the wording with ... in the call to issubclass() as the part that gets repeated is the whole issubclass(x, A), not just the arguments.

@alexpovel
Copy link
Contributor Author

Okay! The PR is updated according to your original suggestion.

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexpovel, looks great!

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexpovel

Sorry for the delayed.
Please rebase your PR to solve the conflict :)

@alexpovel
Copy link
Contributor Author

@corona10 Done!

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit df773f8 into python:master Jun 3, 2020
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

Thanks @alexpovel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @alexpovel, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker df773f8c5454acebe08c31e7308597fa5a8bf5df 3.9

@miss-islington miss-islington self-assigned this Jun 3, 2020
@miss-islington
Copy link
Contributor

Sorry @alexpovel, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker df773f8c5454acebe08c31e7308597fa5a8bf5df 3.8

@miss-islington
Copy link
Contributor

Sorry, @alexpovel, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker df773f8c5454acebe08c31e7308597fa5a8bf5df 3.7

@orsenthil
Copy link
Member

The fix can be ported to other maintained versions of python (3.9, 3.8, 3.7). It looks like automated backport failed.

@alexpovel , would you like to create backport PRs as suggested by the bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.