bpo-40528: Improve AST generation script to do builds simultaneously #19968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getopt => argparse switch (for extendability in the future) - no old-style globals, used arguments to pass over data - Removed limitation of not being able to produce both C and H simultaneously. this will make it run faster since it parses asdl once and uses that tree to generate both header and c source (and in the future maybe python file)
|
You need to update the windows regen files ( |
|
@tonybaloney Can you give us a hand with the |
|
@isidentical tested it on VS2019, builds well with the changes 👍 |
|
Thanks @tonybaloney! |
pablogsal
approved these changes
May 18, 2020
|
Great work @isidentical! And thanks @tonybaloney for the help :) |
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
…ythonGH-19968) - Switch from getopt to argparse. - Removed the limitation of not being able to produce both C and H simultaneously. This will make it run faster since it parses the asdl definition once and uses the generated tree to generate both the header and the C source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will make it run faster since it parses asdl once and uses that tree to
generate both header and c source (and in the future maybe python file)
https://bugs.python.org/issue40528