Skip to content

bpo-38870: Use subTest in test_unparse for better error reporting #20141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2020
Merged

bpo-38870: Use subTest in test_unparse for better error reporting #20141

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7e156a
Use subTest in test_unparse for better error reporting
pablogsal May 17, 2020
ca73ed6
fixup! Use subTest in test_unparse for better error reporting
pablogsal May 17, 2020
c6e8a43
Update Lib/test/test_unparse.py
pablogsal May 17, 2020
bc66e87
Update Lib/test/test_unparse.py
pablogsal May 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions Lib/test/test_unparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,15 @@ def assertASTEqual(self, ast1, ast2):
self.assertEqual(ast.dump(ast1), ast.dump(ast2))

def check_ast_roundtrip(self, code1, **kwargs):
ast1 = ast.parse(code1, **kwargs)
code2 = ast.unparse(ast1)
ast2 = ast.parse(code2, **kwargs)
self.assertASTEqual(ast1, ast2)
with self.subTest(code1=code1, ast_parse_kwargs=kwargs):
ast1 = ast.parse(code1, **kwargs)
code2 = ast.unparse(ast1)
ast2 = ast.parse(code2, **kwargs)
self.assertASTEqual(ast1, ast2)

def check_invalid(self, node, raises=ValueError):
self.assertRaises(raises, ast.unparse, node)
with self.subTest(node=node):
self.assertRaises(raises, ast.unparse, node)

def get_source(self, code1, code2=None):
code2 = code2 or code1
Expand All @@ -135,11 +137,13 @@ def get_source(self, code1, code2=None):

def check_src_roundtrip(self, code1, code2=None):
code1, code2 = self.get_source(code1, code2)
self.assertEqual(code2, code1)
with self.subTest(code1=code1, code2=code2):
self.assertEqual(code2, code1)

def check_src_dont_roundtrip(self, code1, code2=None):
code1, code2 = self.get_source(code1, code2)
self.assertNotEqual(code2, code1)
with self.subTest(code1=code1, code2=code2):
self.assertNotEqual(code2, code1)

class UnparseTestCase(ASTTestCase):
# Tests for specific bugs found in earlier versions of unparse
Expand Down