bpo-40669: Make memory_profiler optional for running PEG benchmarks #20172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
May 18, 2020
| @@ -43,16 +47,17 @@ | |||
|
|
|||
| def benchmark(func): | |||
| def wrapper(*args): | |||
| print(f"{func.__name__}") | |||
There was a problem hiding this comment.
I just ran into a situation where this was quite confusing. make time_compile prints time_compile here. But make time_stdlib_compile also prints time_compile here. Maybe the printing should happen at an earlier point and it should print more info about the parameters to the program?
| print(f"\tMemory: {max(memory)} MiB on an average of 3 runs") | ||
| if MEMORY_BENCHMARKS: | ||
| memory = memory_profiler.memory_usage((func, args)) | ||
| print(f"\tMemory: {max(memory)} MiB on an average of 3 runs") |
There was a problem hiding this comment.
Please add an else: that prints one line of instructions on how to install memory_profiler.
|
Superseded by #20183. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40669