bpo-40989: Move _Py_NewReference() to the internal C API #20904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran a quick test on Cython, numpy and lxml: all projects 3 builds successful. I had to backport a few patches for numpy, to fix another unrelated incompatible changes. I didn't run their test suite. |
|
I completed my PR to remove more functions:
|
Remove the _Py_NewReference() and _Py_ForgetReference() functions from the public C API: move them to the internal C API. Move with_tp_del() test function from the _testcapi module to the _testinternalcapi module.
|
This PR now only makes two (related) functions internals:
I rebased this PR on top of PR #20915 which made _PyTraceMalloc_NewReference() fully internal (don't export it anymore). I changed my mind on _Py_GetRefTotal(): for now, it's fine to keep it as a private function, since sys._gettotalrefcount() private function exists at the Python level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the _Py_NewReference() function from the public C API (move it
to the internal C API).
https://bugs.python.org/issue40989