Skip to content

bpo-40275: Use new test.support helper submodules in tests #21317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 6, 2020
Merged

bpo-40275: Use new test.support helper submodules in tests #21317

merged 13 commits into from
Jul 6, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jul 4, 2020 •
edited
Loading

Use test helpers in the following test cases:

  • tests of distutils
  • test_dbm_gnu
  • test_eof
  • test_hashlib
  • test_idle
  • test_imaplib
  • test_marshal
  • test_py_compile
  • test_set
  • test_socket
  • test_sysconfig
  • test_traceback
  • test_unicode
  • test_xml_etree
  • test_zipfile

https://bugs.python.org/issue40275

@shihai1991 shihai1991 requested review from tiran and a team as code owners July 4, 2020 11:27
@shihai1991
Copy link
Member Author

@vstinner pls take a look if you have free time, thanks.

vstinner
vstinner approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I cannot merge your PR, there is a merge conflict. Please fix the conflict, and ping me when it's done.

vstinner and others added 12 commits July 6, 2020 19:01
@vstinner @shihai1991
bpo-41204: Fix compiler warning in ast_type_init() (pythonGH-21307)
b51f3ca
@methane @shihai1991
Uncomment Py_DEPRECATED for Py_UNICODE APIs (pythonGH-21318)
4ecd411 
PyUnicode_EncodeDecimal and PyUnicode_TransformDecimalToASCII
are deprecated since Python 3.3.
But Py_DEPRECATED(3.3) was commented out.
@methane @shihai1991
bpo-41211: Doc: Fix PyLong_FromUnicodeObject (pythonGH-21325)
20d5076 
It doesn't use PyUnicode_EncodeDecimal. It uses a private API instead.
@ZackerySpytz @shihai1991
bpo-39168: Remove the __new__ method of typing.Generic (pythonGH-21327)
246b2de 
Automerge-Triggered-By: @gvanrossum
@serhiy-storchaka @shihai1991
bpo-36346: Undeprecate private function _PyUnicode_AsUnicode(). (pyth…
bca1003 
…onGH-21336)
@pablogsal @shihai1991
bpo-29727: Register array.array as a MutableSequence (pythonGH-21338)
78fc4bc
@nanjekyejoannah @terryjreedy @shihai1991
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
a085bc2 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@nanjekyejoannah @terryjreedy @shihai1991
bpo-28681: Clarify multiple function names in the tutorial (pythonGH-…
f3ebc64 
…21340)

* improve control flow docs

* Add also

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@methane @shihai1991
bpo-41165: Deprecate PyEval_ReleaseLock() (pythonGH-21309)
4b54378
@shihai1991
bpo-40275: Use new test.support helper submodules in tests (pythonGH-…
abbf2ff 
…21314)
@shihai1991
bpo-40275: Use new test.support helper submodules in tests (pythonGH-…
a32eec0 
…21315)
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_40275_helper_re…
20f3291 
…place_8
@shihai1991
Copy link
Member Author

@vstinner ping : )

@vstinner vstinner merged commit deb0162 into python:master Jul 6, 2020
@shihai1991
Copy link
Member Author

thanks, victor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot @methane @ZackerySpytz @serhiy-storchaka @pablogsal @nanjekyejoannah