Skip to content

bpo-41356: convert bool.__new__ to argument clinic #21581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bpo-41356: convert bool.__new__ to argument clinic #21581

wants to merge 2 commits into from

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Jul 21, 2020 •
edited by bedevere-bot
Loading

corona10
corona10 reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, on my local machine, there was no significant performance improvement.
(0-3% faster)

import pyperf

runner = pyperf.Runner()
runner.timeit(name="bench bool",
              stmt="""
a = bool(1)
b = bool(0)
c = bool()
d = bool(1000)
""")

@sweeneyde sweeneyde closed this Sep 28, 2020
@sweeneyde sweeneyde deleted the bool-arg-clinic branch January 25, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 left review comments

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sweeneyde @corona10 @the-knights-who-say-ni @bedevere-bot