Skip to content

bpo-41445: Added configure temporary files to gitignore #21691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

pokemonish
Copy link
Contributor

@pokemonish pokemonish commented Jul 30, 2020

@methane
Copy link
Member

methane commented Jul 31, 2020

Don't edit configure script directly.
It is generated by configure.ac.
See https://devguide.python.org/setup/#regenerate-configure

@methane
Copy link
Member

methane commented Jul 31, 2020

On my machine, all files generated by configure are ignored. Why do you propose adding these files?

@pokemonish
Copy link
Contributor Author

When I was playing with configure script, I noticed that while configure quite a lot conftest* files are popped out and removed. Also I read that configure does not try to use /tmp directories and so on, because they are not reliable.
If you just run this in one tab:
while true; do git add . && git diff; done
And run this in other one:
./configure
Garbage files will pop in the diff.
By this reason I just tracked genereated files, and put them into .gitignore.

@pokemonish
Copy link
Contributor Author

Maybe it is important
I used linux

@ammaraskar
Copy link
Member

If they're created and removed, is there a reason this should be added to the .gitignore? Under what situation would you be doing git add between the window of running ./configure and it finishing?

@pokemonish
Copy link
Contributor Author

I understand the position that it maybe a kind of overkill to add these files to gitignore.
But on the other side I am not sure that I understand why I can't call git add whenever I wish.

I think that it can be a good idea to create a temporary directory to pass all temporary files, so I tried to understand how to do that in autoconf, but my mind was not still so strong to get to the point of understanding how to do that correctly.

Also Inada Naoki told a good idea about running the ./configure script from other folder to produce a Python build fully there to make it possible not to mix source and build. I like this idea and i will use it, but it is not a forbidden way to call a ./configure in the folder where it is placed.

So, I am questionin myself this question too. Do we need to pass these a little bit akward, but not harmful lines to .gitignore in the name of freedom of using git add or not?

@methane
Copy link
Member

methane commented Aug 1, 2020

As far as I Googled, it is not common convention to add these files to gitignore.
See https://github.com/github/gitignore/blob/master/Autotools.gitignore for example.

@pokemonish
Copy link
Contributor Author

Closing it as not important on bugtracker :)

@pokemonish pokemonish closed this Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants