bpo-41826: add casts for generated C code #22412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Sep 25, 2020
| @@ -319,13 +319,13 @@ def test_same_name_different_types(self) -> None: | |||
|
|
|||
| def test_with_stmt_with_paren(self) -> None: | |||
| grammar_source = """ | |||
| start[mod_ty]: a=[statements] ENDMARKER { Module(a, NULL, p->arena) } | |||
| start[mod_ty]: a=[statements] ENDMARKER { Module((asdl_stmt_seq *)a, NULL, p->arena) } | |||
| statements[asdl_seq*]: a=statement+ { _PyPegen_seq_flatten(p, a) } | |||
There was a problem hiding this comment.
The types in the rules need to be changed accordingly, for instance:
statements[asdl_seq]*
should become
statements[asdl_stmt_seq*]
Ideally, it should be no asdl_seq left
pablogsal
force-pushed
the
bpo-41826
branch
from
21b0ab7
to
17b5be0
Compare
|
I tried to push some fixes to your branch but something has happened and GitHub closed the PR :( |
|
Do you mind re-creating the PR? I opened https://github.com/python/cpython/pull/22455/files in case you don't want (I added you as co-author). If you don't mind, you can recreate this PR from the patch in #22455 (https://patch-diff.githubusercontent.com/raw/python/cpython/pull/22455.patch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add casts to C code fragments used by test_peg_generator.
https://bugs.python.org/issue41826