bpo-25292: asyncio ssl fail hard when writing to closed transport #22541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lib/asyncio/sslproto.py
Outdated
| if self._ssl_protocol._sslpipe is None: | ||
| # The SSL pipe has been destroyed. Writing should fail. | ||
| # See bpo-25292. | ||
| raise BrokenPipeError() |
There was a problem hiding this comment.
I think an error message describing the error might be helpful to the user. Maybe something like
raise BrokenPipeError("SSL pipe is broken") ?
There was a problem hiding this comment.
Thats good. I added your suggested error message
Before this patch, writing to a closed pipe will silently fail. This issue is slightly related to bpo-33037/pythonGH-6044.
|
As per bpo, the ssl implementation was rewritten so this is outdated now, try to create a reproducer and create a new issue if the issue still exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my attempt at bpo-25292 🤗 I hope this is the desired behaviour. Should I add a note to asyncio.StreamWriter.write, mentioning that it can fail with
BrokenPipeError?https://bugs.python.org/issue25292