Check the whitespace of pull requests on Travis #2367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this will block PRs from being submitted if I get this wrong I won't be merging it until someone can provide me an approving review. |
ncoghlan
approved these changes
Jun 24, 2017
| if not fixed: | ||
| print('No whitespace issues found') | ||
| else: | ||
| print(f'Please fix the {len(fixed)} file(s) with whitespace issues') |
There was a problem hiding this comment.
Perhaps specifically mention make patchcheck here? It won't help Windows devs, but it's the easiest option elsewhere.
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 24, 2017
(cherry picked from commit 70cb187)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Jun 24, 2017
(cherry picked from commit 70cb187)
|
GH-2386 is a backport of this pull request to the 3.6 branch. |
|
GH-2387 is a backport of this pull request to the 3.5 branch. |
brettcannon
added a commit
that referenced
this pull request
Jun 25, 2017
brettcannon
added a commit
that referenced
this pull request
Jun 25, 2017
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
|
Sorry, @brettcannon, I could not cleanly backport this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes python/core-workflow#3.