Skip to content

Conversation

spenczar
Copy link

@spenczar spenczar commented Feb 3, 2021

This is the simplest thing I could think of. I'm not very confident in it being the right thing, but it at least fixes my issue.

Things I feel unsure of:

  1. Is calling tasks.sleep(0) really appropriate? A bare yield has the same affect but doesn't require the new import.
  2. Should we only offer to yield for unbounded Queues? Maybe this makes sense even if _maxsize > 0.
  3. The test is not too good. Prior to my change, it wouldn't fail - it would just hang forever. I'd like a race-free way to assert that the execution is not blocked, but I don't know how to do that. The test passes now, but in a regression it might be pretty frustrating to have python -m test hit an infinite loop like this.
  4. This is my first contribution to CPython, so I doubt I did all the news/documentation steps right. Forgive me!

https://bugs.python.org/issue43119

@spenczar spenczar requested a review from rhettinger as a code owner February 3, 2021 20:41
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@spenczar

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 10, 2021
@asvetlov
Copy link
Contributor

See https://bugs.python.org/issue43119#msg413756 for closing reason

@asvetlov asvetlov closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants