Skip to content

bpo-43149: Improve error message for exception group without parentheses #24467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2021
Merged

bpo-43149: Improve error message for exception group without parentheses #24467

merged 1 commit into from
Feb 7, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 7, 2021 •
edited by bedevere-bot
Loading

lysnikolaou
lysnikolaou approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pablogsal pablogsal merged commit 206cbda into python:master Feb 7, 2021
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@pablogsal @adorilson
bpo-43149: Improve error message for exception group without parenthe…
b66fff2 
…ses (pythonGH-24467)
graingert
graingert reviewed May 8, 2021
View reviewed changes
Lib/test/test_syntax.py
@@ -835,6 +835,39 @@
...
SyntaxError: invalid syntax

Check that an exception group with missing parentheses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This terminology conflicts with PEP 654 exception groups

cc @iritkatriel

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. If exceptions group pep is merged we will surely change this sentence.

On the other hand, do you have some alternative phasing for the error you think would be clearer?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isinstance calls this thing a classinfo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/3.10/library/functions.html#isinstance

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I find that even more confusing :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception sequence?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"multiple exception types"?

Copy link
Contributor

@graingert graingert May 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started a mailing list thread in python-dev@python.org "a name for the ExceptHandler.type when it is a literal tuple of types"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iritkatriel yeah I like it: SyntaxError: multiple exception types must be parenthesized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #25996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert graingert left review comments

@iritkatriel iritkatriel iritkatriel left review comments

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @graingert @iritkatriel @lysnikolaou @the-knights-who-say-ni @bedevere-bot