bpo-43178: Redundant method overrides in queue #24488
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
| @@ -0,0 +1 @@ | |||
| Removed redundant method definitions of _qsize in PriorityQueue and LIFOQueue. These methods already inherit the exact same implementation from their parent class, Queue, so these are not necessary | |||
There was a problem hiding this comment.
Without considering the code itself, there is no need for a NEWS entry as this change is not user-facing.
There was a problem hiding this comment.
Sorry. This is my first pull request, I have been trying to follow the tutorial closely. I will pay more attention in the future
There was a problem hiding this comment.
Sorry. This is my first pull request, I have been trying to follow the tutorial closely. I will pay more attention in the future
Is fine, don't worry :)
Normally you need to add a NEWS file, but this is one of the cases were this is not needed.
Do I need to fix this?
Yeah, please, delete this file
Fixed redundant method definitions of _qsize.
https://bugs.python.org/issue43178