Skip to content

bpo-43218: Prevent venv creation when the target directory contains a PATH separator. (GH-24530) #24530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2022
Merged

bpo-43218: Prevent venv creation when the target directory contains a PATH separator. (GH-24530) #24530

merged 1 commit into from
Apr 13, 2022

Conversation

dtrodrigues
Copy link
Contributor

@dtrodrigues dtrodrigues commented Feb 15, 2021 •
edited by bedevere-bot
Loading

@dtrodrigues dtrodrigues requested a review from vsajip as a code owner February 15, 2021 02:15
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2021
@iritkatriel
Copy link
Member

https://bugs.python.org/issue43218 is closed. What is the status of this PR?

@dtrodrigues
Copy link
Contributor Author

I think the BPO issue opener found a workaround but this PR is still useful to prevent somebody from creating a venv that cannot be activated.

@vsajip
Copy link
Member

vsajip commented Apr 13, 2022

I'll close and reopen due to a stalled check.

@vsajip vsajip closed this Apr 13, 2022
@vsajip vsajip reopened this Apr 13, 2022
@vsajip vsajip changed the title bpo-43218: prevent venv creation when target directory contains PATH separator bpo-43218: Prevent venv creation when the target directory contains a PATH separator. (GH-24530) Apr 13, 2022
@vsajip vsajip merged commit 54f67ad into python:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
skip issue stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dtrodrigues @iritkatriel @vsajip @the-knights-who-say-ni @bedevere-bot