Skip to content

[3.6] bpo-30602: Fix refleak in os.spawnv() (#2212) #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2017
Merged

[3.6] bpo-30602: Fix refleak in os.spawnv() (#2212) #2486

merged 1 commit into from
Jun 29, 2017

Conversation

vstinner
Copy link
Member

When os.spawnv() fails while handling arguments, free correctly
argvlist: pass lastarg+1 rather than lastarg to free_string_array()
to also free the first item.
(cherry picked from commit 8acb4cf)

@vstinner
bpo-30602: Fix refleak in os.spawnv() (#2212)
7149837 
When os.spawnv() fails while handling arguments, free correctly
argvlist: pass lastarg+1 rather than lastarg to free_string_array()
to also free the first item.
(cherry picked from commit 8acb4cf)
@bedevere-bot bedevere-bot mentioned this pull request Jun 29, 2017
Merged
@vstinner
Copy link
Member Author

Fix the following leak:

test_os leaked [3, 3, 3] memory blocks, sum=9

http://buildbot.python.org/all/builders/AMD64%20Windows8.1%20Refleaks%203.6/builds/37/steps/test/logs/stdio

@vstinner vstinner merged commit b78fbaa into python:3.6 Jun 29, 2017
@vstinner vstinner deleted the spawnv_leak branch June 29, 2017 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @the-knights-who-say-ni