Skip to content

bpo-43433: Preserve query and fragment in the URL of the server in ServerProxy. #25057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

bpo-43433: Preserve query and fragment in the URL of the server in ServerProxy. #25057

merged 1 commit into from
Mar 29, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 28, 2021 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.9 only security fixes labels Mar 28, 2021
@kynan kynan mentioned this pull request Mar 28, 2021
Closed
kynan
kynan approved these changes Mar 28, 2021
View reviewed changes
Copy link

@kynan kynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM and addresses kynan/dokuwikixmlrpc#8 where the issue was originally reported.

vstinner
vstinner approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding tests!

@corona10 corona10 merged commit c1b073a into python:master Mar 29, 2021
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 29, 2021
@serhiy-storchaka @miss-islington
bpo-43433: Preserve query and fragment in the URL of the server in Se…
1217a3a 
…rverProxy. (pythonGH-25057)

(cherry picked from commit c1b073a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-25068 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 29, 2021
miss-islington added a commit that referenced this pull request Mar 29, 2021
@miss-islington @serhiy-storchaka
bpo-43433: Preserve query and fragment in the URL of the server in Se…
5334605 
…rverProxy. (GH-25057)

(cherry picked from commit c1b073a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@vstinner vstinner mentioned this pull request Mar 29, 2021
Closed
@Julien00859 Julien00859 mentioned this pull request Apr 1, 2021
Closed
@Julien00859
Copy link

Hello there,

For the record, the fragment is client-side only, it should not be sent to the server.

Citing wikipedia:

Clients are not supposed to send URI fragments to servers when they retrieve a document, and without help from a local application (see below) fragments do not participate in HTTP redirections.

Citing the related RFC 3986 - URI

the fragment identifier is not used in the scheme-specific processing of a URI; instead, the fragment identifier is separated from the rest of the URI prior to a dereference, and thus the identifying information within the fragment itself is dereferenced solely by the user agent, regardless of the URI scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@kynan kynan kynan approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@serhiy-storchaka @miss-islington @bedevere-bot @Julien00859 @vstinner @kynan @corona10 @the-knights-who-say-ni