Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] bpo-42083: Allow NULL doc in PyStructSequence_NewType #25896

Merged
merged 2 commits into from
May 4, 2021
Merged

[3.9] bpo-42083: Allow NULL doc in PyStructSequence_NewType #25896

merged 2 commits into from
May 4, 2021

Conversation

encukou
Copy link
Member

@encukou encukou commented May 4, 2021 •
edited by bedevere-bot
Loading

miss-islington and others added 2 commits May 4, 2021 15:22
@miss-islington @Fidget-Spinner @encukou
Add C-API tests (pythonGH-25886) (python#25887)
6ec34a2 
(cherry picked from commit 2f5baa1)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@encukou
[3.9] bpo-42083: Allow NULL doc in PyStructSequence_NewType
bb2d3b3
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented May 4, 2021 •
edited
Loading

Initially I opened GH-25852 which fixed this by checking in PyType_FromModuleAndSpec, but your fix looks like it actually targets the root of it. So I think it's better :).

Edit: Oops I just read your bpo message. Thanks for explaining the other reason too!

@ambv ambv merged commit ec18362 into python:3.9 May 4, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@encukou @Fidget-Spinner @bedevere-bot @ambv @the-knights-who-say-ni @miss-islington