Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40128: Fix IDLE autocomplete on macOS #26672

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Conversation

thsubaku9
Copy link
Contributor

@thsubaku9 thsubaku9 commented Jun 11, 2021

This PR allows autocomplete to work as expected in the MacOS IDLE

https://bugs.python.org/issue40128

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@thsubaku9

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@thsubaku9 thsubaku9 changed the title NAN: Fix for allowing autocomplete to work on MacOS IDLE 40128: Fix for allowing autocomplete to work on MacOS IDLE Jun 11, 2021
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @thsubaku9, please follow the guidelines here: https://devguide.python.org/pullrequest/#submitting to link the issue to the PR correctly.

@terryjreedy terryjreedy changed the title 40128: Fix for allowing autocomplete to work on MacOS IDLE bpo-40128: Fix IDLE autocomplete on macOS Jun 11, 2021
@terryjreedy terryjreedy added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes and removed skip news labels Jun 11, 2021
@terryjreedy
Copy link
Member

Kaustubh: I normally do not look as substantive (behavior-changing) diffs until the CLA is recorded as signed. Because completions have been such an issue on macOS, I peeked. Because the fix, which I regard as a bug workaround, is so trivial, I finished the PR and will merge it when CE passes. However, I hope you sign if you have not and look at more bugs.

If you do not know, merging a PR branch into main is not needed; you can made the PR directly from the branch. When the branch is checked out, update-merge upstream/main into the branch with the same command used to update local main.

@terryjreedy terryjreedy merged commit 3ec3ee7 into python:main Jun 11, 2021
@miss-islington
Copy link
Contributor

Thanks @thsubaku9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @thsubaku9 and @terryjreedy, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3ec3ee7d2e9b45b586e486e429b412d6d0ca530f 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 3ec3ee7)

Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jun 11, 2021
@bedevere-bot
Copy link

GH-26683 is a backport of this pull request to the 3.9 branch.

@terryjreedy terryjreedy added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Jun 11, 2021
@miss-islington
Copy link
Contributor

Thanks @thsubaku9 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 3ec3ee7)

Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 11, 2021
@bedevere-bot
Copy link

GH-26684 is a backport of this pull request to the 3.10 branch.

terryjreedy pushed a commit that referenced this pull request Jun 11, 2021
In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 3ec3ee7)

Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
terryjreedy pushed a commit that referenced this pull request Jun 11, 2021
In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 3ec3ee7)

Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
@thsubaku9
Copy link
Contributor Author

Kaustubh: I normally do not look as substantive (behavior-changing) diffs until the CLA is recorded as signed. Because completions have been such an issue on macOS, I peeked. Because the fix, which I regard as a bug workaround, is so trivial, I finished the PR and will merge it when CE passes. However, I hope you sign if you have not and look at more bugs.

If you do not know, merging a PR branch into main is not needed; you can made the PR directly from the branch. When the branch is checked out, update-merge upstream/main into the branch with the same command used to update local main.

Alright, I'll keep this in mind for my future submits. I've signed the CLA but I guess it takes some time to update on the site

jdevries3133 pushed a commit to jdevries3133/cpython that referenced this pull request Jun 19, 2021
In particular, when running with tk8.6.8, as in PSF 3.9. 

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@taleinat
Copy link
Contributor

@terryjreedy
Please note that this broke completions for me with Tcl/Tk 8.6.11 on Ubuntu 20.04.

@taleinat
Copy link
Contributor

Apparently also with Tcl/Tk 8.6.10, which is the current default.

Also broken in my latest install of Python 3.9.7 (not built from source).

@terryjreedy
Copy link
Member

See issue.

pablogsal pushed a commit that referenced this pull request Sep 14, 2021
In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 3ec3ee7)

Co-authored-by: Kaustubh J <kaustubhkj@gmail.com>
@dvd101x
Copy link

dvd101x commented Jan 22, 2022

I noticed that selecting Edit>Show Completions works as expected on Python 3.10.2 and macOS 12.1

IDLE edit menu

But trying the default keyboard shortcut ^S only highlights the edit menu but doesn't work.

I understand that it's supposed to be ^space because that's how it works on windows and it also works in macOS after disabling the default behavior for ^space but this doesn't highlight the edit menu.

So the mismatch is like this:

Shortcut Works Conflict with macOS Displayed Highlights menu
^S No No Yes Yes
^space Yes Yes No No

@taleinat
Copy link
Contributor

taleinat commented Jan 23, 2022

Hey @dvd101x, that looks like a separate issue than the one fixed here. Would you mind opening a new ticket on bugs.python.org with these details?

@dvd101x
Copy link

dvd101x commented Jan 24, 2022

Yes of course. I saw this referenced on the original issue https://bugs.python.org/issue40128 but it also makes sense for to separate into a different issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants