Skip to content

bpo-44453: Fix return type documentation for sysconfig.get_path() #26785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Jun 18, 2021

The current documentation says it returns None if the name is not found, but
the implementation uses [] and will raise KeyError instead.

Noticed by @srittau in python/typeshed#5659.

https://bugs.python.org/issue44453

…nd, but

the implementation uses [] and will raise KeyError instead.

Noticed by @srittau in python/typeshed@5659.
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 18, 2021
@JelleZijlstra JelleZijlstra added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jun 18, 2021
@srittau
Copy link
Contributor

srittau commented Jun 18, 2021

Thanks!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 19, 2021
@ambv ambv merged commit f22737a into python:main Jul 26, 2021
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27371 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 26, 2021
@bedevere-bot
Copy link

GH-27372 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2021
…nd, but (pythonGH-26785)

the implementation uses [] and will raise KeyError instead.

Noticed by @srittau in python/typeshed@5659.
(cherry picked from commit f22737a)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 26, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2021
…nd, but (pythonGH-26785)

the implementation uses [] and will raise KeyError instead.

Noticed by @srittau in python/typeshed@5659.
(cherry picked from commit f22737a)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra deleted the getpath branch July 26, 2021 16:50
ambv pushed a commit that referenced this pull request Jul 26, 2021
…nd, but (GH-26785) (GH-27371)

the implementation uses [] and will raise KeyError instead.

Noticed by @srittau in python/typeshed@5659.
(cherry picked from commit f22737a)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
ambv pushed a commit that referenced this pull request Jul 26, 2021
…nd, but (GH-26785) (GH-27372)

the implementation uses [] and will raise KeyError instead.

Noticed by @srittau in python/typeshed@5659.
(cherry picked from commit f22737a)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants