-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
bpo-44453: Fix return type documentation for sysconfig.get_path() #26785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd, but the implementation uses [] and will raise KeyError instead. Noticed by @srittau in python/typeshed@5659.
Thanks! |
This PR is stale because it has been open for 30 days with no activity. |
Thanks @JelleZijlstra for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
GH-27371 is a backport of this pull request to the 3.10 branch. |
GH-27372 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2021
…nd, but (pythonGH-26785) the implementation uses [] and will raise KeyError instead. Noticed by @srittau in python/typeshed@5659. (cherry picked from commit f22737a) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 26, 2021
…nd, but (pythonGH-26785) the implementation uses [] and will raise KeyError instead. Noticed by @srittau in python/typeshed@5659. (cherry picked from commit f22737a) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation says it returns None if the name is not found, but
the implementation uses [] and will raise KeyError instead.
Noticed by @srittau in python/typeshed#5659.
https://bugs.python.org/issue44453