bpo-44654: Do not export the union type related symbols #27223
Conversation
| @@ -8,13 +8,13 @@ extern "C" { | |||
| # error "this header requires Py_BUILD_CORE define" | |||
| #endif | |||
|
|
|||
| PyAPI_DATA(PyTypeObject) _PyUnion_Type; | |||
There was a problem hiding this comment.
All the extern keywords here are optional right?
There was a problem hiding this comment.
It is required for variable declarations and optional for function declarations. But other function declarations in headers have extern.
There was a problem hiding this comment.
I see, thanks. This LGTM. But you might have trouble backporting to 3.10 due to the ABI check.
There was a problem hiding this comment.
Actually the ABI check does not complain when we stop exporting some symbols. It only complains if we add some new exported symbols.
There was a problem hiding this comment.
Actually the ABI check does not complain when we stop exporting some symbols. It only complains if we add some new exported symbols.
Fixing this in #27229. The check is backwards
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
…nGH-27223). (cherry picked from commit 8f50f44) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-27225 is a backport of this pull request to the 3.10 branch. |
* origin/main: (1146 commits) bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155) bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249) correct spelling (pythonGH-27076) bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237) bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797) Clean up comma usage in Doc/library/functions.rst (python#27083) bpo-42238: Fix small rst issue in NEWS.d/. (python#27238) bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091) bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231) bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206) bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216) bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810) bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992) bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402) bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032) bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278) bpo-44654: Do not export the union type related symbols (pythonGH-27223) bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218) bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196) bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211) ...
https://bugs.python.org/issue44654