bpo-41546: make pprint (like print) not write to stdout when it is None #26810
Conversation
iritkatriel
changed the title
|
Any more comments before I merge? |
Lib/test/test_pprint.py
Outdated
| with contextlib.redirect_stdout(None): | ||
| # smoke test - there is no output to check | ||
| pprint.pprint(simple) |
There was a problem hiding this comment.
Is not it already tested in test_stdout_is_None?
There was a problem hiding this comment.
You're right, this is no longer needed, I'll remove. With my first (more complex) solution this covered more code paths.
|
Please document this behavior in the module documentation and add the versionchanged directive. |
Done. Probably not part of this PR, but I don't think the doc needs to repeat this twice. Could we not refer from pprint()'s doc to PrettyPrinter.pprint()'s doc? |
|
Why not in this PR? |
Sure, if you don't mind mixing two celebrations. |
…es for shared parameters.
@serhiy-storchaka I've made the doc change, let me know if it looks ok. |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
| Added the *sort_dicts* parameter. | ||
|
|
||
| .. versionchanged:: 3.10 | ||
| Added the *underscore_numbers* parameter. |
There was a problem hiding this comment.
Why remove versionchanged notes? People need to know this.
There was a problem hiding this comment.
We're removing the repetitions.
There was a problem hiding this comment.
But these are not needless repetitions: they are separate notes on separate functions.
There was a problem hiding this comment.
We removed repetition not only of the version labels but also of the definitions they relate to, and we replaced them by a reference to where those definitions appear (once).
It is easier read the docs when they are not repetitive because then you know that A is the same as B, and you don't need to do the work to compare them just to find that out.
|
|
The build failure seems unrelated to this change: |
* origin/main: (1146 commits) bpo-42064: Finalise establishing sqlite3 global state (pythonGH-27155) bpo-44678: Separate error message for discontinuous padding in binascii.a2b_base64 strict mode (pythonGH-27249) correct spelling (pythonGH-27076) bpo-44524: Add missed __name__ and __qualname__ to typing module objects (python#27237) bpo-27513: email.utils.getaddresses() now handles Header objects (python#13797) Clean up comma usage in Doc/library/functions.rst (python#27083) bpo-42238: Fix small rst issue in NEWS.d/. (python#27238) bpo-41972: Tweak fastsearch.h string search algorithms (pythonGH-27091) bpo-44340: Add support for building with clang full/thin lto (pythonGH-27231) bpo-44661: Update property_descr_set to use vectorcall if possible. (pythonGH-27206) bpo-44645: Check for interrupts on any potentially backwards edge (pythonGH-27216) bpo-41546: make pprint (like print) not write to stdout when it is None (pythonGH-26810) bpo-44554: refactor pdb targets (and internal tweaks) (pythonGH-26992) bpo-43086: Add handling for out-of-spec data in a2b_base64 (pythonGH-24402) bpo-44561: Update hyperlinks in Doc/distributing/index.rst (python#27032) bpo-42355: symtable.get_namespace() now checks whether there are multiple or any namespaces found (pythonGH-23278) bpo-44654: Do not export the union type related symbols (pythonGH-27223) bpo-44633: Fix parameter substitution of the union type with wrong types. (pythonGH-27218) bpo-44654: Refactor and clean up the union type implementation (pythonGH-27196) bpo-20291: Fix MSVC warnings in getargs.c (pythonGH-27211) ...
https://bugs.python.org/issue41546