Skip to content

DOC: Fix typos in Enum example #27363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2021
Merged

DOC: Fix typos in Enum example #27363

merged 1 commit into from
Jul 26, 2021

Conversation

Kaniee
Copy link
Contributor

@Kaniee Kaniee commented Jul 26, 2021

Initially I wanted to fix the typo with "naem", when I realized that there are missing parentheses for the today and isoweekday function call.
In my opinion, readability could be improved by making it a f-string:

print(f'today is {cls(date.today().isoweekday()).name}')

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@Kaniee

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 26, 2021
@ambv ambv added the needs backport to 3.10 only security fixes label Jul 26, 2021
@ambv ambv merged commit 6c7ec72 into python:main Jul 26, 2021
@miss-islington
Copy link
Contributor

Thanks @Kaniee for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @Kaniee and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6c7ec7282b68dcd0f3af0f1ccc6345da4bc06931 3.10

@ethanfurman ethanfurman removed the needs backport to 3.10 only security fixes label Jul 26, 2021
@ethanfurman
Copy link
Member

The docs in 3.11 are massively different from the 3.9/3.10 docs. No backport needed.

@Kaniee Kaniee deleted the patch-1 branch July 27, 2021 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants