Skip to content

bpo-34013: Generalize the invalid legacy statement error message #27389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2021
Merged

bpo-34013: Generalize the invalid legacy statement error message #27389

merged 1 commit into from
Jul 27, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 27, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jul 27, 2021
@pablogsal pablogsal requested a review from lysnikolaou as a code owner July 27, 2021 10:14
@pablogsal pablogsal requested a review from iritkatriel July 27, 2021 10:14
@pablogsal
Copy link
Member Author

One possibility we can do is eliminate the custom code and just go with this error always (no "did you mean 'print(...)'").

lysnikolaou
lysnikolaou approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement.

iritkatriel
iritkatriel approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ammaraskar ammaraskar mentioned this pull request Jul 27, 2021
Closed
@pablogsal pablogsal merged commit 6948964 into python:main Jul 27, 2021
@pablogsal pablogsal deleted the bpo-34013 branch July 27, 2021 16:19
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6948964ecf94e858448dd28eea634317226d2913 3.10

@bedevere-bot
Copy link

GH-27391 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2021
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jul 27, 2021
@pablogsal
[3.10] bpo-34013: Generalize the invalid legacy statement error messa…
20f0f53 
…ge (pythonGH-27389).

(cherry picked from commit 6948964)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jul 27, 2021
@pablogsal
[3.10] bpo-34013: Generalize the invalid legacy statement error messa…
b977f85 
…ge (GH-27389). (GH-27391)

(cherry picked from commit 6948964)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pablogsal @miss-islington @bedevere-bot @iritkatriel @lysnikolaou @the-knights-who-say-ni