bpo-44793: Fix checking the number of arguments when subscribe a gene… #27515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
type-bug
serhiy-storchaka
force-pushed
the
typing-generic-paramspec-numargs
branch
from
14d2277 to
fa6937f
Compare
…ric type with ParamSpec parameter. For example Callable[P, T][[int], str, float] will now raise an error. Use also the term "arguments" instead of "parameters" in error message for too few/many arguments.
serhiy-storchaka
force-pushed
the
typing-generic-paramspec-numargs
branch
from
fa6937f to
0db1b4d
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-27537 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 2, 2021
…ric type with ParamSpec parameter. (pythonGH-27515) For example Callable[P, T][[int], str, float] will now raise an error. Use also term "arguments" instead of "parameters" in error message for too few/many arguments. (cherry picked from commit f92b913) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Aug 2, 2021
…ric type with ParamSpec parameter. (GH-27515) For example Callable[P, T][[int], str, float] will now raise an error. Use also term "arguments" instead of "parameters" in error message for too few/many arguments. (cherry picked from commit f92b913) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
Sorry, I wasn't able to review this on time Serhiy. Looking at this after the merge, it looks good. Thanks! |
|
It would be good to have a review, but I merged this PR because it is relatively simple and is a prerequisite of other more complex changes. The code changed in this PR will likely be rewritten in future, I am just not sure that that changes will be backported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ric type with ParamSpec parameter.
For example Callable[P, T][[int], str, float] will now raise an error.
Use also the term "arguments" instead of "parameters" in error
message for too few/many arguments.
https://bugs.python.org/issue44793