Skip to content

bpo-34013: Don't consider a grouped expression when reporting legacy print syntax errors #27521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2021
Merged

bpo-34013: Don't consider a grouped expression when reporting legacy print syntax errors #27521

merged 1 commit into from
Aug 1, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 31, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner July 31, 2021 23:15
@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Jul 31, 2021
@pablogsal pablogsal requested a review from brandtbucher July 31, 2021 23:16
@pablogsal
Copy link
Member Author

@brandtbucher Could you review this at the earliest convenience? I would like to land this before the end of tomorrow so I can release the rc on schedule.

brandtbucher
brandtbucher approved these changes Aug 1, 2021
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@pablogsal pablogsal merged commit 208a7e9 into python:main Aug 1, 2021
@pablogsal pablogsal deleted the bpo-34013 branch August 1, 2021 01:10
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27522 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 1, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 1, 2021
@pablogsal @miss-islington
bpo-34013: Don't consider a grouped expression when reporting legacy …
28db635 
…print syntax errors (pythonGH-27521)

(cherry picked from commit 208a7e9)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Aug 1, 2021
@miss-islington @pablogsal
bpo-34013: Don't consider a grouped expression when reporting legacy …
35035bc 
…print syntax errors (GH-27521)

(cherry picked from commit 208a7e9)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @brandtbucher @the-knights-who-say-ni