Skip to content

Conversation

yatharthmathur
Copy link

@yatharthmathur yatharthmathur commented Aug 18, 2021

Python heapq module doesn't have an implementation of Max Heap by default and the internal private methods implemented for the same don't have a push functionality. This might be useful for users in case they require a max heap functionality for non trivial comparable objects.

https://bugs.python.org/issue44944

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@yatharthmathur

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@yatharthmathur yatharthmathur changed the title Added _heappush_max implementation for max heap push in heapq bpo-44944 Added _heappush_max implementation for max heap push in heapq Aug 18, 2021
@yatharthmathur yatharthmathur changed the title bpo-44944 Added _heappush_max implementation for max heap push in heapq bpo-44944: Added _heappush_max implementation for max heap push in heapq Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants