[3.10] bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194) #28199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1st1 and @pablogsal: Status check is done, and it's a success ✅ . |
|
@1st1 and @pablogsal: Status check is done, and it's a success ✅ . |
pablogsal
previously approved these changes
Sep 7, 2021
|
@1st1 and @pablogsal: Status check is done, and it's a success ❌ . |
…H-28194) Fix PyAiter_Check to only check for the `__anext__` presense (not for `__aiter__`). Rename `PyAiter_Check()` to `PyAIter_Check()`, `PyObject_GetAiter()` -> `PyObject_GetAIter()`. Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> (cherry picked from commit 2c3474a) Co-authored-by: Yury Selivanov <yury@edgedb.com>
pablogsal
force-pushed
the
backport-2c3474a-3.10
branch
from
f211414 to
404b740
Compare
pablogsal
approved these changes
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PyAiter_Check to only check for the
__anext__presense (not for__aiter__). RenamePyAiter_Check()toPyAIter_Check(),PyObject_GetAiter()->PyObject_GetAIter().Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com
(cherry picked from commit 2c3474a)
Co-authored-by: Yury Selivanov yury@edgedb.com
https://bugs.python.org/issue45123