-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
bpo-42135 Correct version slated for importlib.find_loader removal #28312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
importlib.find_loader should also be slated for 3.12 like the others in pythonGH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.html#deprecated
Yep, should be backported. And a news file wouldn't hurt, but the docs are really the key thing along with What's New. |
brettcannon
approved these changes
Sep 13, 2021
News file added. |
@hugovk: Status check is done, and it's a success ❌ . |
Thanks @hugovk for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
GH-28321 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2021
…ythonGH-28312) importlib.find_loader should also be slated for 3.12 like the others in pythonGH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.htmlGH-deprecated. (cherry picked from commit 9f93018) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
brettcannon
pushed a commit
that referenced
this pull request
Sep 13, 2021
…H-28312) (GH-28321) importlib.find_loader should also be slated for 3.12 like the others in GH-25169 and as documented in https://docs.python.org/3.11/whatsnew/3.10.htmlGH-deprecated. (cherry picked from commit 9f93018) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
importlib.find_loader
should also be slated for removal in Python 3.12 instead of Python 3.10, like the others in GH-25169, and as documented in:https://bugs.python.org/issue42135
Automerge-Triggered-By: GH:brettcannon