bpo-31019: multiprocessing.Pool.terminate() now joins "dead" processes #2849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpo-31019: Pool.terminate() now also joins "dead" processes even if their is_alive() method returns false. The change prevents leaking "dangling" processes.
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @shibturn and @jnoller to be potential reviewers. |
|
I tried to write an unit test, but it's hard to write a reliable test :-( Once all debug checks will be added to http://bugs.python.org/issue26762 it will be trivial to see the effect of this bug fix. |
vstinner
changed the title
vstinner
changed the title
|
Abandonned in favor of PR 2875 which fixes the root issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-31019: Pool.terminate() now also joins "dead" processes even if
their is_alive() method returns false. The change prevents leaking
"dangling" processes.
https://bugs.python.org/issue31019