bpo-45116 Fix another performance regression on Windows #28630
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not reviewed this but this PR should not be landed before #28488, otherwise is going to be a nightmare to validate that code path again. |
But that is designed like that on pourpose, and has proven to improve performance in the past. This would need some validation because AFAIK it goes against previous work and knowledge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, MSVC tends to share the same code blocks in a too big function.
In the ceval-loop,
NEXTOPARG()orDISPATCH()macros are unexpectedly shared and joined with (long) jump instructions, which disturb PGO profiling.With this PR, MSVC seems to generate expected codes for #25244.
https://bugs.python.org/issue45116