Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30778: Skip test_bsddb3 on Windows XP #2877

Merged
merged 2 commits into from
Jul 26, 2017
Merged

bpo-30778: Skip test_bsddb3 on Windows XP #2877

merged 2 commits into from
Jul 26, 2017

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 26, 2017 •
edited by bedevere-bot
Loading

@vstinner vstinner added OS-windows tests Tests in the Lib/test dir labels Jul 26, 2017
@vstinner vstinner requested a review from zware July 26, 2017 00:22
@vstinner vstinner closed this Jul 26, 2017
@vstinner vstinner reopened this Jul 26, 2017
@vstinner
Copy link
Member Author

PR closed then reopened to retry AppVeyor. Previously, AppVeyor failed with: "continuous-integration/appveyor/pr — AppVeyor was unable to build non-mergeable pull request".

zware
zware reviewed Jul 26, 2017
View reviewed changes
Lib/test/test_bsddb3.py Outdated
@@ -28,6 +28,10 @@
verbose = False
sys.argv.remove('silent')

# bpo-30778: test_bsddb3 crashs randomly on Windows XP
if hasattr(sys, 'getwindowsversion') and sys.getwindowsversion()[:2] <= (6, 0):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.0 was Vista which we don't want to skip, so < rather than <=.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I know that, it's a mistake. It's now fixed.

zware
zware approved these changes Jul 26, 2017
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could play code golf to get it down to (or beyond) if getattr(sys, 'getwindowsversion', lambda: (9,))()[:1] < (6,):, but this is fine as is :)

@vstinner vstinner merged commit 0cba38d into python:2.7 Jul 26, 2017
@vstinner vstinner deleted the test_bsddb3_xp branch July 26, 2017 15:55
@vstinner
Copy link
Member Author 

if getattr(sys, 'getwindowsversion', lambda: (9,))()[:1] < (6,):

Nice one, but I prefer my syntax ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
OS-windows tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @zware @the-knights-who-say-ni