Skip to content

bpo-45489: Update ForwardRef to support | operator. #28991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 16, 2021

@corona10
Copy link
Member Author

corona10 commented Oct 16, 2021

@Fidget-Spinner If I understood Guido and your comment, this change is a new feature rather than bugfix right?

I saw your backport label :)

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Oct 16, 2021

@Fidget-Spinner If I understood Guido and your comment, this change is a new feature rather than bugfix right?

Hmm, I think it's OK to backport it as bugfix to 3.10, (I also don't see any way it could cause incompatbility). I'll wait for Guido to comment though.

@Fidget-Spinner Fidget-Spinner removed the needs backport to 3.10 only security fixes label Oct 16, 2021
@corona10 corona10 merged commit 15ad52f into python:main Oct 16, 2021
@corona10 corona10 deleted the bpo-45489 branch October 16, 2021 15:13
@gvanrossum
Copy link
Member

It’s a feature and would be different between 3.10.0 and 3.10.1 if backported, so it should not be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants