-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
bpo-42413: Replace concurrent.futures.TimeoutError
and asyncio.TimeoutError
with builtin TimeoutError
#30197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvetlov
reviewed
Dec 19, 2021
asvetlov
approved these changes
Dec 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Dec 27, 2021
…eoutError` with builtin `TimeoutError` (pythonGH-30197) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
dthain
pushed a commit
to cooperative-computing-lab/cctools
that referenced
this pull request
Sep 16, 2024
* raise task exceptions in python task futures * wrap FutureFunctionCall tracebacks in FunctionCallNoResult * Raise TimeoutError in Future when task result is pending * yield futures and raise TimeoutError in as_completed * Improve error handling in wait * Import TimeoutError for Python <3.10 compatibility In Python 3.9 and older, concurrent.futures used its own TimeoutError class rather than the builtin. TimeoutError is aliased to the builtin in layer Python versions, so for backwards compatibility we import it in the test file. See python/cpython#30197
colinthomas-z80
pushed a commit
to colinthomas-z80/cctools
that referenced
this pull request
Oct 15, 2024
…rative-computing-lab#3922) * raise task exceptions in python task futures * wrap FutureFunctionCall tracebacks in FunctionCallNoResult * Raise TimeoutError in Future when task result is pending * yield futures and raise TimeoutError in as_completed * Improve error handling in wait * Import TimeoutError for Python <3.10 compatibility In Python 3.9 and older, concurrent.futures used its own TimeoutError class rather than the builtin. TimeoutError is aliased to the builtin in layer Python versions, so for backwards compatibility we import it in the test file. See python/cpython#30197
btovar
pushed a commit
to cooperative-computing-lab/cctools
that referenced
this pull request
Oct 21, 2024
* raise task exceptions in python task futures * wrap FutureFunctionCall tracebacks in FunctionCallNoResult * Raise TimeoutError in Future when task result is pending * yield futures and raise TimeoutError in as_completed * Improve error handling in wait * Import TimeoutError for Python <3.10 compatibility In Python 3.9 and older, concurrent.futures used its own TimeoutError class rather than the builtin. TimeoutError is aliased to the builtin in layer Python versions, so for backwards compatibility we import it in the test file. See python/cpython#30197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Andrew Svetlov andrew.svetlov@gmail.com
https://bugs.python.org/issue42413
https://bugs.python.org/issue42413