Skip to content

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Dec 19, 2021

@kumaraditya303
Copy link
Contributor Author

cc @asvetlov I rebased your original PR #23520 and fixed merge conflicts and docs so that this can be committed for 3.11. Thanks

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@asvetlov asvetlov merged commit da4b214 into python:main Dec 19, 2021
@kumaraditya303 kumaraditya303 deleted the unify-timeout-error branch December 20, 2021 08:50
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Dec 27, 2021
…eoutError` with builtin `TimeoutError` (pythonGH-30197)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
dthain pushed a commit to cooperative-computing-lab/cctools that referenced this pull request Sep 16, 2024
* raise task exceptions in python task futures

* wrap FutureFunctionCall tracebacks in FunctionCallNoResult

* Raise TimeoutError in Future when task result is pending

* yield futures and raise TimeoutError in as_completed

* Improve error handling in wait

* Import TimeoutError for Python <3.10 compatibility

In Python 3.9 and older, concurrent.futures used its own TimeoutError
class rather than the builtin. TimeoutError is aliased to the builtin in
layer Python versions, so for backwards compatibility we import it in
the test file.

See python/cpython#30197
colinthomas-z80 pushed a commit to colinthomas-z80/cctools that referenced this pull request Oct 15, 2024
…rative-computing-lab#3922)

* raise task exceptions in python task futures

* wrap FutureFunctionCall tracebacks in FunctionCallNoResult

* Raise TimeoutError in Future when task result is pending

* yield futures and raise TimeoutError in as_completed

* Improve error handling in wait

* Import TimeoutError for Python <3.10 compatibility

In Python 3.9 and older, concurrent.futures used its own TimeoutError
class rather than the builtin. TimeoutError is aliased to the builtin in
layer Python versions, so for backwards compatibility we import it in
the test file.

See python/cpython#30197
btovar pushed a commit to cooperative-computing-lab/cctools that referenced this pull request Oct 21, 2024
* raise task exceptions in python task futures

* wrap FutureFunctionCall tracebacks in FunctionCallNoResult

* Raise TimeoutError in Future when task result is pending

* yield futures and raise TimeoutError in as_completed

* Improve error handling in wait

* Import TimeoutError for Python <3.10 compatibility

In Python 3.9 and older, concurrent.futures used its own TimeoutError
class rather than the builtin. TimeoutError is aliased to the builtin in
layer Python versions, so for backwards compatibility we import it in
the test file.

See python/cpython#30197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants