-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
bpo-37295: Speed up math.comb(n, k) for 0 <= k <= n <= 67 #30275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mdickinson
merged 6 commits into
python:main
from
mdickinson:faster-math-comb-for-tiny-inputs
Dec 28, 2021
Merged
bpo-37295: Speed up math.comb(n, k) for 0 <= k <= n <= 67 #30275
mdickinson
merged 6 commits into
python:main
from
mdickinson:faster-math-comb-for-tiny-inputs
Dec 28, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
commented
Dec 27, 2021
mdickinson
commented
Dec 27, 2021
Fix array name in a comment; be consistent about operator spacing.
mdickinson
commented
Dec 27, 2021
rhettinger
approved these changes
Dec 27, 2021
tim-one
approved these changes
Dec 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice and very clear. Ship it 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up
math.comb(n, k)
for very smallk
andn
.The existing tests already include exhaustive testing of correctness of
math.comb(n, k)
for0 <= k <= n <= 100
, so I didn't add any more unit tests.Some sample timings on my machine (comparing commit fd3a4bb on this branch with commit 2e3e0d2 on the main branch):
./python.exe -m timeit -s "from math import comb;n, k = 1, 1" "comb(n, k)"
: difference not significant./python.exe -m timeit -s "from math import comb;n, k = 5, 3" "comb(n, k)"
: ~23% faster (but may not be significant)./python.exe -m timeit -s "from math import comb;n, k = 67, 25" "comb(n, k)"
: ~9.7x fasterhttps://bugs.python.org/issue37295