Skip to content

bpo-46306: simplify CodeType attribute access in doctest.py #30481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 8, 2022

Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ericvsmith
Copy link
Member

Does this need backporting?

@sobolevn
Copy link
Member Author

sobolevn commented Jan 8, 2022

@ericvsmith this was 18 years old before I've changed it 🤔
Probably it can be an improvement only.

@ericvsmith
Copy link
Member

Heh. Okay.

@ericvsmith ericvsmith merged commit 0fc58c1 into python:main Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants