Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-46520: Handle identifiers that look like keywords in ast.unparse #31012

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Kodiologist
Copy link
Contributor

@Kodiologist Kodiologist commented Jan 29, 2022

Handle identifiers that look like keywords in ast.unparse

https://bugs.python.org/issue46520

@terryjreedy
Copy link
Member

@ezio-melotti Did you intend to remove the CLA-signed label? (I saw this on another PR and wondered there too.) Does Kodi need to sign or re-sign to get this reviewed?

@terryjreedy
Copy link
Member

Kodi, please replace your private joke and its response with a draft commit message. At first glance, it makes this look like spam, and obstructing merging that way makes this look non-serious.

@ezio-melotti
Copy link
Member

ezio-melotti commented Aug 9, 2022

@terryjreedy: the CLA-signed label got removed and replaced by the clabot. All PRs must now pass the "CLA Signing" check before being merged. You can retrigger the check by closing and reopening the PR.

Edit: clicking on the "Update branch" button should also retrigger the check.

@Kodiologist
Copy link
Contributor Author

Kodi, please replace your private joke and its response with a draft commit message.

I've changed the text of the first post, but I don't have the power to change or remove reactions, if that's what you mean by "its response". In fact, I don't think GitHub lets any users do that.

@terryjreedy terryjreedy closed this Aug 9, 2022
@terryjreedy terryjreedy reopened this Aug 9, 2022
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Aug 9, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@terryjreedy
Copy link
Member

Kodi, whatever you did before, you need to sign or re-sign the CLA

@Kodiologist
Copy link
Contributor Author

I signed it previously (by mail, if I recall correctly) and I got "Internal Server Error" when trying to click through the Heroku program, but @cpython-cla-bot seems to now think it's signed, so eh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants