Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46647: make sure test_functools works with and without _functoolsmodule #31141

Closed
wants to merge 1 commit into from
Closed

bpo-46647: make sure test_functools works with and without _functoolsmodule #31141

wants to merge 1 commit into from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 5, 2022 •
edited

Additional notes:

  • After all the refactorings test.test_functools.TestPartialC.test_pickle started to fail, so I had to add the same tweak with AllowPickle that we use for py_functools
  • I've also removed unused imports while I was there

Proof that it works now:
Снимок экрана 2022-02-05 в 14 31 00

https://bugs.python.org/issue46647

@sobolevn
Copy link
Member Author

sobolevn commented Feb 5, 2022

CI failure is not related, I've opened a new issue for it: https://bugs.python.org/issue46648

@sobolevn sobolevn closed this Feb 5, 2022
@sobolevn sobolevn reopened this Feb 5, 2022
@sobolevn sobolevn closed this Feb 8, 2022
This was referenced Apr 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@shihai1991 shihai1991 Awaiting requested review from shihai1991

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sobolevn @the-knights-who-say-ni @bedevere-bot