Skip to content

bpo-46721: Optimize set.issuperset() for non-set arguments #31280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2022
Merged

bpo-46721: Optimize set.issuperset() for non-set arguments #31280

merged 3 commits into from
Apr 6, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 11, 2022 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the performance Performance or resource usage label Feb 11, 2022
@sweeneyde
Copy link
Member

Is it possible that someone is relying on some_set.issuperset(iterable) consuming all of iterable? It does seem unlikely and fragile, but I just wanted to double-check.

@serhiy-storchaka
Copy link
Member Author

Yes, it is possible, but I do not think there is much such code. We cannot double-check this.

@serhiy-storchaka
Copy link
Member Author

@rhettinger, could you please look at this PR and #31316?

@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 17, 2022
Merged
@serhiy-storchaka serhiy-storchaka merged commit a69a4a9 into python:main Apr 6, 2022
@serhiy-storchaka serhiy-storchaka deleted the set-issuperset branch April 6, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweeneyde sweeneyde sweeneyde approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @sweeneyde @raghavthind2005 @the-knights-who-say-ni @bedevere-bot