[3.10] Minor fixes to C API docs (GH-31501) #31524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* C API docs: move PyErr_SetImportErrorSubclass docs It was in the section about warnings, but it makes more sense to put it with PyErr_SetImportError. * C API docs: document closeit argument to PyRun_AnyFileExFlags It was already documented for PyRun_SimpleFileExFlags. * textual fixes to unicode docs * Move paragraph about tp_dealloc into tp_dealloc section * __aiter__ returns an async iterator, not an awaitable (cherry picked from commit 43cf44d) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
@JelleZijlstra: Status check is done, and it's a failure ❌ . |
1 similar comment
|
@JelleZijlstra: Status check is done, and it's a failure ❌ . |
JelleZijlstra
approved these changes
Feb 23, 2022
|
@JelleZijlstra: Status check is done, and it's a success ✅ . |
|
@JelleZijlstra: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was in the section about warnings, but it makes more sense to
put it with PyErr_SetImportError.
It was already documented for PyRun_SimpleFileExFlags.
textual fixes to unicode docs
Move paragraph about tp_dealloc into tp_dealloc section
aiter returns an async iterator, not an awaitable
(cherry picked from commit 43cf44d)
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com