Skip to content

bpo-1207613: Add scrollbar to IDLE editor #32116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-1207613: Add scrollbar to IDLE editor #32116

wants to merge 1 commit into from

Conversation

justsomenewgui
Copy link

@justsomenewgui justsomenewgui commented Mar 25, 2022

Create AutoHideScrollbar in editor.py

https://bugs.python.org/issue1207613

Create AutoHideScrollbar in editor.py
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@justsomenewgui

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Mariatta
Copy link
Member

I think this needs a ticket in bugs.python.org.
You should also create your branch off the main branch instead of the 3.9 branch.
And finally, you'll need to write tests.

@terryjreedy
Copy link
Member

terryjreedy commented Mar 25, 2022

Please read the relevant sections of the developers' guide https://devguide.python.org/.

I will not look at this until you are recorded as having signed the CLA. But see below.

Nearly all PRs, including this one, must be against the main branch. You will probably have to close this. But do CLA first and see below.

Addition's like this need an issue. If this is about adding a horizontal scrollbar, there already is one: bpo-1207613. There is also a patch: #1984. It was not merged because there were issues with the autohide behavior. See both the issue and PR.

We are supposedly switching to github issues this weekend. I don't know how that will affect the CLA and review processes.

@terryjreedy terryjreedy changed the title Update editor.py bpo-1207613: Add scrollbar to IDLE editor Mar 25, 2022
@Mariatta
Copy link
Member

The GitHub Issues migration has been postponed to April 1st. Source: https://discuss.python.org/t/github-issues-migration-status-update/14573

@terryjreedy
Copy link
Member

Closing because no CLA and because a quick glance shows this to be a duplicate of a subset of the existing patch #1984.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants