-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
bpo-35095: Add append_bytes() and append_text() to Path class #3811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Ok, already signed. Waiting for profile update. |
Thanks for the PR. You'll need to create an issue in bugs.python.org for this. |
As no issue was ever created I'm closing the PR. If one ever is to open discussion on the idea and it's generally accepted we can re-open the PR. |
Why not just |
@brettcannon The issue is created indeed, on 2018-10-28. See https://bugs.python.org/issue35095 |
@keelung-yang unfortunately the bugs.python.org issue was not added to the PR as required by our workflow, so the PR got closed. And now the PR is so old it is against the |
Having
read_bytes()
,read_text()
,write_bytes()
andwrite_text
(), one would expect to findappend_bytes()
andappend_text()
methods in the Path class.https://bugs.python.org/issue35095