Skip to content

bpo-35095: Add append_bytes() and append_text() to Path class #3811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-35095: Add append_bytes() and append_text() to Path class #3811

wants to merge 1 commit into from

Conversation

nuno-andre
Copy link
Contributor

@nuno-andre nuno-andre commented Sep 28, 2017

Having read_bytes(), read_text(), write_bytes() and write_text(), one would expect to find append_bytes() and append_text() methods in the Path class.

https://bugs.python.org/issue35095

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@nuno-andre
Copy link
Contributor Author

Ok, already signed. Waiting for profile update.

@Mariatta
Copy link
Member

Mariatta commented Oct 3, 2017

Thanks for the PR. You'll need to create an issue in bugs.python.org for this.

@brettcannon brettcannon added the type-feature A feature request or enhancement label Mar 29, 2019
@brettcannon
Copy link
Member

As no issue was ever created I'm closing the PR. If one ever is to open discussion on the idea and it's generally accepted we can re-open the PR.

@keelung-yang
Copy link

Why not just Path.write_*(, append=False) as discussed in https://stackoverflow.com/questions/57296168/pathlib-path-write-text-in-append-mode

@keelung-yang
Copy link

As no issue was ever created I'm closing the PR.

@brettcannon The issue is created indeed, on 2018-10-28. See https://bugs.python.org/issue35095
So it shouldn't be closed on 2019-03-30

@brettcannon brettcannon changed the title Add append_bytes() and append_text() to Path class bpo-35095: Add append_bytes() and append_text() to Path class Jan 24, 2022
@brettcannon brettcannon requested review from pablogsal and removed request for pablogsal January 24, 2022 21:03
@brettcannon
Copy link
Member

brettcannon commented Jan 24, 2022

@keelung-yang unfortunately the bugs.python.org issue was not added to the PR as required by our workflow, so the PR got closed. And now the PR is so old it is against the master branch which no longer exists so I can't re-open the PR even if I wanted to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review type-feature A feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants