Skip to content

bpo-31709: Update importlib magic #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2017
Merged

bpo-31709: Update importlib magic #3906

merged 3 commits into from
Oct 6, 2017

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Oct 6, 2017 •
edited by bedevere-bot
Loading

@1st1 1st1 self-assigned this Oct 6, 2017
@1st1 1st1 requested a review from a team October 6, 2017 06:21
@1st1 1st1 removed the request for review from a team October 6, 2017 06:22
@1st1 1st1 added the skip news label Oct 6, 2017
@1st1
Copy link
Member Author

1st1 commented Oct 6, 2017

NEWS entry was provided as part of #3903. This is a simple follow up to that PR.

@ncoghlan
Copy link
Contributor

ncoghlan commented Oct 6, 2017

Ah, right, I missed that - you need this to force the removal of the no-longer-needed await logic.

ncoghlan
ncoghlan requested changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts, could you also add a .. versionchanged: 3.7 note for the opcode docs in the dis module?

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@1st1
Copy link
Member Author

1st1 commented Oct 6, 2017

I didn't expect the Spanish Inquisition!

@bedevere-bot
Copy link

Nobody expects the Spanish Inquisition!

@ncoghlan: please review the changes made to this pull request.

@1st1
Copy link
Member Author

1st1 commented Oct 6, 2017

On second thoughts, could you also add a .. versionchanged: 3.7 note for the opcode docs in the dis module?

Good catch!

@ncoghlan
Copy link
Contributor

ncoghlan commented Oct 6, 2017

@1st1 This one LGTM now as well :)

@1st1 1st1 merged commit 02e82a0 into python:master Oct 6, 2017
@1st1 1st1 deleted the magic branch October 6, 2017 14:18
@1st1
Copy link
Member Author

1st1 commented Oct 6, 2017

Thanks again, Nick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

@1st1 1st1

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1st1 @ncoghlan @bedevere-bot @the-knights-who-say-ni