Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32370: Use the correct encoding for ipconfig output in the uuid module #5608

Merged
merged 2 commits into from Feb 13, 2018
Merged

bpo-32370: Use the correct encoding for ipconfig output in the uuid module #5608

merged 2 commits into from Feb 13, 2018

Conversation

segevfiner
Copy link
Contributor

@segevfiner segevfiner commented Feb 10, 2018 •
edited by bedevere-bot

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Feb 11, 2018
@serhiy-storchaka serhiy-storchaka merged commit da6c3da into python:master Feb 13, 2018
@miss-islington
Copy link
Contributor

Thanks @segevfiner for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2018
@segevfiner @miss-islington
bpo-32370: Use the correct encoding for ipconfig output in the uuid m…
2e0f80e 
…odule. (pythonGH-5608)

(cherry picked from commit da6c3da)

Co-authored-by: Segev Finer <segev208@gmail.com>
@bedevere-bot
Copy link

GH-5652 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @segevfiner and @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker da6c3da6c33c6bf794f741e348b9c6d86cc43ec5 3.6

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Feb 13, 2018
@segevfiner @serhiy-storchaka
[3.6] bpo-32370: Use the correct encoding for ipconfig output in the …
82184b5 
…uuid module. (pythonGH-5608).

(cherry picked from commit da6c3da)

Co-authored-by: Segev Finer <segev208@gmail.com>
@bedevere-bot
Copy link

GH-5654 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Feb 13, 2018
@miss-islington @segevfiner
bpo-32370: Use the correct encoding for ipconfig output in the uuid m…
9b5a90b 
…odule. (GH-5608)

(cherry picked from commit da6c3da)

Co-authored-by: Segev Finer <segev208@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Feb 13, 2018
@serhiy-storchaka @segevfiner
[3.6] bpo-32370: Use the correct encoding for ipconfig output in the …
c3f9d7e 
…uuid module. (GH-5608). (#5654)

(cherry picked from commit da6c3da)


Co-authored-by: Segev Finer <segev208@gmail.com>
@segevfiner segevfiner deleted the bpo-32370-uuid-ipconfig-encoding branch February 14, 2018 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@segevfiner @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni