Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-10381, bpo-32403: What's new entries for changes to datetime #5814

Merged
merged 2 commits into from Feb 27, 2018

Conversation

Projects
None yet
6 participants
@pganssle
Copy link
Contributor

pganssle commented Feb 22, 2018

This adds "What's New" entries for two datetime-related improvements I made in #4993 (bpo-32403) and #5032 (bpo-10381).

For the "optimizations" one, I was not sure how best to measure the improvement in speed but I just put "significant". My initial benchmarks suggest that some of the constructors have as much as 100% speed improvement, but none of that was done against an optimized build.

https://bugs.python.org/issue10381

pganssle added some commits Feb 22, 2018

@abalkin

This comment has been minimized.

Copy link
Member

abalkin commented Feb 22, 2018

@ned-deily - I am not sure what the procedure is for adding What's New in 3.7 entries. Please advise.

The text LGTM.

@ned-deily

This comment has been minimized.

Copy link
Member

ned-deily commented Feb 22, 2018

@abalkin After merging to the master branch, you should only need to backport to 3.7 like any other change and that should happen automatically.

@pganssle

This comment has been minimized.

Copy link
Contributor Author

pganssle commented Feb 22, 2018

Should I try to do some sort of benchmarking before this is merged to give an estimate of the order of magnitude of the speedup?

@ned-deily

This comment has been minimized.

Copy link
Member

ned-deily commented Feb 22, 2018

@pganssle As far as I'm concerned, "significant" is sufficient. Thanks for doing this.

@abalkin abalkin closed this Feb 27, 2018

@abalkin abalkin reopened this Feb 27, 2018

@abalkin abalkin merged commit 5bd04f9 into python:master Feb 27, 2018

4 checks passed

bedevere/issue-number Issue number 10381 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Feb 27, 2018

Thanks @pganssle for the PR, and @abalkin for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖 I'm not a witch! I'm not a witch!

miss-islington added a commit to miss-islington/cpython that referenced this pull request Feb 27, 2018

bpo-10381, bpo-32403: What's new entries for changes to datetime (pyt…
…hongh-5814)

* Add What's New entry for addition of datetime.timezone to the C API

Closes bpo-10381

* Add what's new entry for date and datetime optimizations

Closes bpo-32403
(cherry picked from commit 5bd04f9)

Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Feb 27, 2018

GH-5929 is a backport of this pull request to the 3.7 branch.

abalkin added a commit that referenced this pull request Feb 27, 2018

bpo-10381, bpo-32403: What's new entries for changes to datetime (gh-…
…5814) (gh-5929)

* Add What's New entry for addition of datetime.timezone to the C API

Closes bpo-10381

* Add what's new entry for date and datetime optimizations

Closes bpo-32403
(cherry picked from commit 5bd04f9)

Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>

@pganssle pganssle deleted the pganssle:datetime-whatsnew branch Oct 25, 2018

yahya-abou-imran added a commit to yahya-abou-imran/cpython that referenced this pull request Nov 2, 2018

bpo-10381, bpo-32403: What's new entries for changes to datetime (pyt…
…hongh-5814)

* Add What's New entry for addition of datetime.timezone to the C API

Closes bpo-10381

* Add what's new entry for date and datetime optimizations

Closes bpo-32403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.