Skip to content

[3.7] bpo-32819: Simplify and improve ssl.match_hostname (GH-5620) #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2018
Merged

[3.7] bpo-32819: Simplify and improve ssl.match_hostname (GH-5620) #5847

merged 1 commit into from
Feb 24, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 24, 2018 •
edited by bedevere-bot
Loading

ssl.match_hostname() has been simplified and no longer depends on re and
ipaddress module for wildcard and IP addresses. Error reporting for invalid
wildcards has been improved.

Signed-off-by: Christian Heimes christian@python.org
(cherry picked from commit aef1283)

Co-authored-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32819

@tiran @miss-islington
bpo-32819: Simplify and improve ssl.match_hostname (pythonGH-5620)
281a5b0 
ssl.match_hostname() has been simplified and no longer depends on re and
ipaddress module for wildcard and IP addresses. Error reporting for invalid
wildcards has been improved.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit aef1283)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Feb 24, 2018
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error type-security A security issue labels Feb 24, 2018
@miss-islington
Copy link
Contributor Author

@tiran: Backport status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@tiran: Backport status check is done, and it's a success ✅ .

@tiran tiran merged commit 46632f4 into python:3.7 Feb 24, 2018
@miss-islington
Copy link
Contributor Author

Thanks, @tiran!

@bedevere-bot
Copy link

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-aef1283-3.7 branch February 24, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @bedevere-bot @tiran @the-knights-who-say-ni