bpo-30406: allow async/await in lib2to3 #6143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac31770. (Reverts only the lib2to3 part.)
|
Jelle, thanks a ton for working on this! I will merge as soon as tests pass. |
ambv
approved these changes
Mar 18, 2018
|
Thanks @JelleZijlstra for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2018
…" (pythonGH-6143) This reverts commit ac31770. (Reverts only the lib2to3 part.) (cherry picked from commit f64aae4) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
GH-6145 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Mar 18, 2018
jo2y
pushed a commit
to jo2y/cpython
that referenced
this pull request
Mar 23, 2018
pythonGH-6143) This reverts commit ac31770. (Reverts only the lib2to3 part.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the lib2to3 changes in commit ac31770. As @ambv pointed out in #1669 (comment), this change is unnecessary and broke usage of 2to3 for pre-3.7 code.
This should be backported to 3.7 because it fixes a regression that was introduced by ac31770.
https://bugs.python.org/issue30406