bpo-33175: dataclasses should look up __set_name__ on class, not instance #6305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JelleZijlstra, can you take a look? |
| @@ -0,0 +1,2 @@ | |||
| In dataclasses, Field.__set_name__ now looks up the __set_name__ special | |||
There was a problem hiding this comment.
Does this need a NEWS entry if there was no release with the buggy code? (I'm mostly curious; you'll know the norms better than I do.)
There was a problem hiding this comment.
I thought about this, but unfortunately I think it does need the NEWS blurb. Ned has already cut 3.7.0b3, so the bug will be in that release. Thanks again for catching this.
JelleZijlstra
approved these changes
Mar 29, 2018
|
Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-6309 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 29, 2018
…ance (pythonGH-6305) (cherry picked from commit 5219952) Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue33175