Skip to content

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 5, 2018

The Opera Browser was using an outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

  • Correct the arguments passed to the Opera Browser when opening a new URL..
    (cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim k.bumsik@gmail.com

https://bugs.python.org/issue34019

The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.

* Correct the arguments passed to the Opera Browser when opening a new URL..
(cherry picked from commit 3cf1f15)

Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tried to backport test_webbrowser, but it requires a lot of changes.

@pablogsal pablogsal merged commit 8902a1d into python:2.7 Jul 6, 2018
@bedevere-bot
Copy link

@pablogsal: Please replace # with GH- in the commit message next time. Thanks!

@pablogsal pablogsal deleted the backport-3cf1f15-2.7 branch July 6, 2018 23:54
@pablogsal
Copy link
Member Author

pablogsal commented Jul 6, 2018

@bedevere-bot The backport made me put my guard down 😮 I won't fail again :)

holatuwol added a commit to holatuwol/liferay-faster-deploy that referenced this pull request Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants