Skip to content

bpo-1539381: Implement SpooledTemporaryFile.readinto #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alanjds
Copy link

@alanjds alanjds commented Jul 24, 2018

SpooledTemporaryFile have no readinto because of StringIO absence of it.

However, SpooledTemporaryFile have 3 internal "modes": BytesIO, StringIO and TemporaryFile.

This PR allows it use and expose .readinto of the modes that allows it. And the one that does not will raise its exception.

https://bugs.python.org/issue1539381

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@corona10
Copy link
Member

@alanjds
Brett Cannon already rejected this issue.
I think you should send a new discussion into Python-dev.

@alanjds
Copy link
Author

alanjds commented Jul 30, 2018

Ok. Thanks. I will take a look on how to send discussions there.

Should it go to python-ideas before, or is not necessary?

@corona10
Copy link
Member

@corona10
Copy link
Member

I've send simillar discussion before but I only send dev.

@iritkatriel
Copy link
Member

Closing as https://bugs.python.org/issue1539381 was rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants